Lgtm.
There’s a similar issue with ‘{‘’}’ you might want to fix separately, except in
the opposite direction :), e.g., in
test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/MethodBind/JvmtiTest/JvmtiTest.cpp,
+#define JVMTI_ERROR_CHECK(str,res) if (res != JVMTI_ERROR_NONE) { printf(str);
printf("%d\n",res); return res;}
+#define JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if (res != err) {
printf(str); printf("unexpected error %d\n",res); return res;}
=>
+#define JVMTI_ERROR_CHECK(str,res) if (res != JVMTI_ERROR_NONE) { printf(str);
printf("%d\n",res); return res; }
+#define JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if (res != err) {
printf(str); printf("unexpected error %d\n",res); return res; }
And somewhat different in
test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/aod/jvmti_aod.cpp
+ (threadConstructor = NSK_CPP_STUB4(GetMethodID, jni, klass,
"<init>", "()V")) != NULL)) {
=>
+ (threadConstructor = NSK_CPP_STUB4(GetMethodID, jni, klass,
"<init>", "()V")) != NULL)) {
Paul
From: serviceability-dev <serviceability-dev-boun...@openjdk.java.net> on
behalf of "serguei.spit...@oracle.com" <serguei.spit...@oracle.com>
Date: Monday, October 22, 2018 at 3:15 PM
To: JC Beyler <jcbey...@google.com>, "serviceability-dev@openjdk.java.net"
<serviceability-dev@openjdk.java.net>
Subject: Re: RFR (M) 8212771: Remove remaining spaces before/after () for
vmTestbase
Hi Jc,
It looks good.
Thanks!
Serguei
On 10/22/18 11:30, JC Beyler wrote:
Hi all,
Here is the last webrev (3 out of 3) to remove the spaces after/before () from
vmTestbase. It is straightforward and I generated the webrev with white-space
changes showing up of course:
Webrev:
http://cr.openjdk.java.net/~jcbeyler/8212771/webrev.00/<http://cr.openjdk.java.net/%7Ejcbeyler/8212771/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8212771
Could I please get some reviews?
Thanks,
Jc
