Re: RFR (M) 8201655: Add thread-enabled support for the Heap Sampling

Mon, 05 Nov 2018 12:59:59 -0800

Hi Jc,

I'm looking at it now.
Need to double-check something.

Thanks,
Serguei


On 10/26/18 10:48, JC Beyler wrote:
Hi all,

When working on the heap sampling, I had promised to do the per thread event so here it is! 

Could I get a review for this:

I was thinking of adding GC-dev for the memAllocator change once I get favorable reviews for the rest of the change.

I've done a bit of performance testing and on the Dacapo benchmark I see no change in performance when turned off (logical, any code change is behind a flag check already in place) and when turned on it is comparable to the current performance.

(More information is: I see a very slight degradation if we are doing 512k sampling but no degradation at 2MB). 

Thanks,
Jc

Reply via email to