On Fri, 9 Nov 2018 at 16:02, Severin Gehwolf <sgehw...@redhat.com> wrote: > > Hi, > > Could somebody please review this 8u backport of 8210836 as I'd like to > get 8210647 (opt for sa) backported to 8u as well? Unfortunately the > change from JDK 12 doesn't apply cleanly so I've included select > changes from 8140482 so that the backport remains minimal. If anything, > this makes the code more robust I'd think. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8210836 > webrev: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210836/jdk8/webrev.01/ > > Testing: Manual testing of loading core file in SA on linux. Stepping > through code in the debugger. Basic jsadebugd core file loading. > > Thoughts? > > Thanks, > Severin > >
Is there a reason not to just backport https://bugs.openjdk.java.net/browse/JDK-8140482 as a pre-requisite for this? It looks pretty uncontroversial (a lot of it is indenting fixes), makes the code a little more secure and would help any future backports in these areas if the code is in sync. The resulting backport of 8210836 would then be largely as is and may not even require review. -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Web Site: http://fuseyism.com Twitter: https://twitter.com/gnu_andrew_java PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
