Hi JC,

Looks great. Thanks for the cleanup.

Chris


On 11/20/18 4:27 PM, JC Beyler wrote:
Hi all,

As we work out the details for removing the NSK*VERIFY macros and the assignments in ifs in those cases, here is a webrev for assignments without the macros.


I've launched testing for the whole vmTestbase test suite since this touched a few shared files. I don't expect any surprises :-).

Note that, technically, we could also do the alternative of adding the macros for each if statement instead :). I'd rather just move the assignments out and then, as we agree about how to roll out a better tracing/verification mechanism across the vmTestbase code base, we will automatically encompass these and thus add coverage at that moment.

Thanks,
Jc


Reply via email to