Hi, On Tue, 2018-11-20 at 10:38 -0800, [email protected] wrote: > Hi Simon, > > It looks good. > Thank you for taking care about this! > > The same question if you need a sponsor here.
I'll sponsor this for Simon. Thanks, Severin > Thanks, > Serguei > > > On 11/20/18 06:41, Simon Tooke wrote: > > Hello, > > > > I'm not sure if this belongs in the serviceability group, but the tests > > are for jvmti, so it seemed appropriate. > > Please point me elsewhere if not. > > > > Two tests define a ClassUnload() callback function with an incorrect > > parameter,"jvmtiEnv jvmti_env", instead of "jvmtiEnv* jvmti_env". > > > > This will lead to an invalid cast warning on some compilers, but > > currently has no impact on the tests as ex03t001 is disabled, and the > > body of the other ClassUnload() is empty. These issues were found by > > compiling with GCC 8.1. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214108 > > webrev: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/stooke/JDK-8214108/01/webrev/ > > > > For what it's worth, ex03t001 does pass if enabled, but I don't know if the > > test is correct at this point; it's been disabled for a while. > > > > Please let me know what you think, > > > > Thanks, > > -Simon > > > >
