Sorry -- missed adding this. If we are convinced after the extra
diagnostics that getMethod() returning NULL is a valid scenario (could
SA be attaching at an unstable moment?), maybe we could improve the test
case(s) then to handle this situation gracefully.
Thank you,
Jini.
On 12/14/2018 12:11 PM, Jini George wrote:
Hi Sharath,
Since this is a duplicate of
https://bugs.openjdk.java.net/browse/JDK-8196969, I am not sure if
trying to confirm that this occurs only with -Xcomp will help. (I think
we are already mostly convinced about that -- as per the comments in
JDK-8196969). I guess we should try to fix the actual issue of the
getMethod() returning NULL. We could probably have a subtask under this
for putting in extra diagnostics in the code to check why getMethod()
would return NULL.
But if you think we need to do any test case improvements for this, we
could -- but probably as a separate bug or a subtask.
Thanks,
Jini.
On 12/13/2018 12:11 PM, Sharath Ballal wrote:
Hi,
Pls review the test fix in serviceability/sa/ClhsdbFindPC.java
Jira: https://bugs.openjdk.java.net/browse/JDK-8211923
Webrev: http://cr.openjdk.java.net/~sballal/8211923/webrev.00/
I have done the following modifications to the testcase:
1. If jstack output does not contain "LingeredApp.main", fail the test.
2. The test is testing both -Xcomp and -Xint options. I have changed
the order of the test and made -Xint first. Currently the failure is
in -Xcomp. Changing the order will tell us (in future failures) if the
interpretted mode passed or not.
SA tests passed in Mach5 runs.
Thanks,
Sharath
