Hi Serguei, Thanks for reviewing. > On Fri, 2019-02-01 at 12:11 -0800, [email protected] wrote: > > Hi Zhengyu, > > > > > > > > I do not have enough expertise in this area but it looks good > > to > > me. > > > > > > > > > > > > http://cr.openjdk.java.net/~zgu/JDK-8212127/webrev.00/src/hotspot/s > > hare/gc/shared/threadLocalAllocBuffer.hpp.udiff.html > > > > > > > > Minor comment: > > > > void update_fast_allocations(unsigned int refills, > > size_t allocations, > > size_t gc_waste, > > - size_t fast_refill_waste, > > size_t slow_refill_waste); > > The slow_refill_waste > > needs to be renamed to refill_waste.
Fixed in place. -Zhengyu > > > > > > > > > > Thanks, > > > > Serguei > > > > > > > > > > > > On 2/1/19 10:27, > > [email protected] wrote: > > > > > > After FastTLABRefill was removed, let's cleanup related perf > > counters. > > I removed perf counters for fast refill, and renamed perf counters > > for > > slow refill. > > > > I am not all clear what implication of renaming/removing exported > > symbols, and have no idea what aliasmap is for. So I ran all tests > > I > > think could be affected, showed no problem. > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8212127 > > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8212127/webrev.00/ > > > > Test: > > hotspot_runtime, hotspot_serviceability, > > vmTestbase_nsk_monitoring, > > vmTestbase_nsk_jdi, vmTestbase_nsk_jvmti, vmTestbase_vm_jdwp > > on Linux x64 > > > > Eyeball output of jsnap > > > > Thanks, > > > > -Zhengyu > > > > > > > > >
