Hi Gary, The webrev looks good to me (I don't like the general way the tests are written with "i" as a test iterator but that's a different conversation ;-))
Thanks, Jc On Mon, Feb 4, 2019 at 6:03 AM Gary Adams <[email protected]> wrote: > Two of the redefine classes tests (021, 023) have been on the > ProblemList since they > were first brought into the open repos. Both tests made an incorrect > assumption > about the access modifiers in class files. There is a single bit in the > binary class file that > defines if an interface is public or not public (See JVMS Table 4.1-B > ACC_PUBLIC). > When the test classes are compiled for use in the redefine operation, if > a source > used public or protected the ACC_PUBLIC bit was set. > > Several modifiers are used in these tests to confirm > UnsupportedOperationException > is thrown or not thrown. This proposed change simply corrects the > expected results > according to the JVM Specification. > > Webrev: http://cr.openjdk.java.net/~gadams/8065773/webrev.00/index.html > -- Thanks, Jc
