Thank you, Serguei and Gary, for reviewing this change! --Daniil
On 3/6/19, 8:57 AM, "Gary Adams" <[email protected]> wrote: Looks OK to me. On 3/5/19, 5:47 PM, [email protected] wrote: > Hi Daniil, > > The fix looks good. > > Thanks, > Serguei > > > On 3/5/19 1:59 PM, Daniil Titov wrote: >> Please review a fix for this test that intermittently fails with >> Graal on. >> >> The problem here is that the test does two consequent calls to >> VirtualMachine.allThreads() and checks that the number of threads >> returned by these calls is the same. With Graal on there is a chance >> that a new JVMCI compiler thread could be started between these calls >> that makes test to fail. The fix temporary suspends the debuggee VM >> while these two calls to VirtualMachine.allThreads() are made. >> >> Webrev: http://cr.openjdk.java.net/~dtitov/8218464/webrev.01 >> Bug: https://bugs.openjdk.java.net/browse/JDK-8218464 >> >> Thanks! >> --Daniil >> >> >> >
