Re: 6504660: HPI panic callback is dead code

[Chris Plummer]

Hi Brian, The indentation of this comment is off, and I think it should say "Unix", not "Solaris".   88   /* On Solaris, there is only one encoding method. */ Otherwise it looks good. I don't need to see another webrev. Thanks for cleaning this up. Chris On 3/8/19 1:12 AM, Brian Burkhalter wrote: Looping in serviceability-dev@openjdk.java.net. Thanks, Brian Begin forwarded message: From: Claes Redestad <claes.redes...@oracle.com> Subject: Re: 6504660: HPI panic callback is dead code Date: March 7, 2019 at 9:43:45 AM GMT To: Brian Burkhalter <brian.burkhal...@oracle.com>, core-libs-dev <core-libs-...@openjdk.java.net> Hi Brian, looks fine! Thanks! /Claes On 2019-03-07 10:39, Brian Burkhalter wrote: Please review this fix [1] to remove dead code [2]. Thanks, Brian [1] http://cr.openjdk.java.net/~bpb/6504660/webrev.00/ [2] https://bugs.openjdk.java.net/browse/JDK-6504660