Yes for me :) (though I'm not a Reviewer and I don't like commented code generally, for diagnostic tests I usually just put a flag that is off by default but no need to change it for me/this :-)), Jc
On Wed, Mar 13, 2019 at 8:55 AM Gary Adams <[email protected]> wrote: > One last set of diffs ... > - added comments on the ignored exceptions > - commented out excessive diagnostic print out > (this will remove the jtreg truncated output) > > Ok to use dan, dean and jc as reveiwers? > > diff --git a/test/jdk/com/sun/jdi/SimulResumerTest.java > b/test/jdk/com/sun/jdi/SimulResumerTest.java > --- a/test/jdk/com/sun/jdi/SimulResumerTest.java > +++ b/test/jdk/com/sun/jdi/SimulResumerTest.java > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2008, 2015, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2008, 2019, Oracle and/or its affiliates. All rights > reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -210,7 +210,9 @@ > } > > } catch (IncompatibleThreadStateException ee) { > - // ignore > + // ignore checks if thread was not suspended > + } catch (ObjectCollectedException ee) { > + // ignore checks if thread was collected > } catch (VMDisconnectedException ee) { > // This is how we stop. The debuggee runs to completion > // and we get this exception. > @@ -249,7 +251,7 @@ > public void run() { > while (true) { > iters++; > - System.out.println("bkpts = " + bkpts + ", > iters = " + iters); > + // System.out.println("bkpts = " + bkpts + ", > iters = " + iters); > try { > Thread.sleep(waitTime); > check(debuggeeThread1); > > > > On 3/7/19, 8:19 AM, Gary Adams wrote: > > While trying to reproduce the timeout reported in > > JDK-8000669: com/sun/jdi/SimulResumerTest.java times out > > > > I was unable to reproduce the timeout failure, but I did occasionally > > see the ObjectCollectedException. The output from the test is very > > verbose > > and may be the source of the occasional timeout. I'd like to close > > JDK-8000669 > > as cannot reproduce and if it shows up again look into limiting the > > amount > > of non-essential output from the test. > > > > This is a racy test to begin with and it already is ignoring exceptions > > due to unexpected thread states. Adding the ignore for > > ObjectCollectedException > > allows the test to complete without errors. > > > > The graal label was recently removed. We should also remove it from > > the summary. > > > > Proposed changeset: > > > > > > diff --git a/test/jdk/com/sun/jdi/SimulResumerTest.java > > b/test/jdk/com/sun/jdi/SimulResumerTest.java > > --- a/test/jdk/com/sun/jdi/SimulResumerTest.java > > +++ b/test/jdk/com/sun/jdi/SimulResumerTest.java > > @@ -1,5 +1,5 @@ > > /* > > - * Copyright (c) 2008, 2015, Oracle and/or its affiliates. All rights > > reserved. > > + * Copyright (c) 2008, 2019, Oracle and/or its affiliates. All rights > > reserved. > > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > > * > > * This code is free software; you can redistribute it and/or modify it > > @@ -211,6 +211,8 @@ > > > > } catch (IncompatibleThreadStateException ee) { > > // ignore > > + } catch (ObjectCollectedException ee) { > > + // ignore > > } catch (VMDisconnectedException ee) { > > // This is how we stop. The debuggee runs to completion > > // and we get this exception. > > -- Thanks, Jc
