Re: RFR(M): 8220628: Move the HeapMonitor library to C++

Wed, 13 Mar 2019 18:02:14 -0700

Hi JC,

Looks good. My only question is your use of reinterpret_cast instead of static_cast. Not an area of C++ I know much about, other than  having just read some varying opinions that aren't all that good at explaining what's going on.

thanks,

Chris

On 3/13/19 4:07 PM, Jean Christophe Beyler wrote:
Hi all,

Could I get a review of:

I've not tried to do anything special here to keep the review simple; in the next webrev or two, I'll move more code to more C++ style and then work on diagnostic print-outs (in C++ :-)) to figure out the issues with the bugs related to these tests.

This passed testing on my dev machine and a submit repo run (which I'm not sure runs these test but still good to check).

Thanks!
Jc


Reply via email to