Re: RFR: JDK-8220295: sun/tools/jps/TestJps.java still timing out

[Chris Plummer]

Hi Gary, For the most part I think this fix is fine. However, you might want to file two followup bugs: 1. jtreg exclusiveAccess.dirs help text is incorrect. If it was correct, your fix would not work. 2. It's still not clear why these tests often don't play nice together. You suggested (offline) that it might have to do with the fact that two tests are trying to attach to each other at the same time, and this might be resulting in a deadlock. I would like to see a bug filed to eventually look into that. A stress test that spawns multiple tests that try to attach to each other should not be that hard write. I think all you need to do is exec() a bunch of jps processes. thanks, Chris On 3/19/19 5:22 AM, Gary Adams wrote: After 1000 testruns on {solaris,linux,windows,macosx} debug builds running    test/jdk/sun/tools   test/jdk/com/sun/tools/attach with this change, no failures were observed in TestJps or TempDirTest. diff --git a/test/jdk/TEST.ROOT b/test/jdk/TEST.ROOT --- a/test/jdk/TEST.ROOT +++ b/test/jdk/TEST.ROOT @@ -22,7 +22,11 @@  javax/management sun/awt sun/java2d javax/xml/jaxp/testng/validation java/lang/ProcessHandle    # Tests that cannot run concurrently -exclusiveAccess.dirs=java/rmi/Naming java/util/prefs sun/management/jmxremote sun/tools/jstatd sun/security/mscapi java/util/stream java/util/Arrays/largeMemory java/util/BitSet/stream javax/rmi +exclusiveAccess.dirs=java/rmi/Naming java/util/prefs sun/management/jmxremote \ +sun/tools/jstatd sun/tools/jcmd sun/tools/jhsdb sun/tools/jhsdb/heapconfig \ +sun/tools/jinfo sun/tools/jmap sun/tools/jps sun/tools/jstack sun/tools/jstat \ +com/sun/tools/attach sun/security/mscapi java/util/stream java/util/Arrays/largeMemory \ +java/util/BitSet/stream javax/rmi  # Group definitions  groups=TEST.groups   Failures were observed in the following tests. sun/tools/jstat/jstatLineCounts4.sh,[],[solaris-sparcv9-debug],[ExitCode: 1],[bug4990825 shell], [jstatLineCounts4.sh],[37605],[] sun/tools/jstat/jstatLineCounts4.sh,[],[solaris-sparcv9-debug],[ExitCode: 1],[bug4990825 shell], [jstatLineCounts4.sh],[37605],[]   sun/tools/jstat/jstatLineCounts3.sh sun/tools/jstat/jstatLineCounts4.sh,[],[solaris-sparcv9-debug],[ExitCode: 1],[bug4990825 shell], [jstatLineCounts4.sh],[37605],[] sun/tools/jstat/jstatLineCounts4.sh,[],[solaris-sparcv9-debug],[ExitCode: 1],[bug4990825 shell], [jstatLineCounts4.sh],[37605],[]   sun/tools/jstat/jstatLineCounts4.sh   sun/tools/jstatd/TestJstatdDefaults.java   sun/tools/jstatd/TestJstatdServer.java   sun/tools/jstatd/TestJstatdPort.java   sun/tools/jstatd/TestJstatdExternalRegistry.java I'll investigate those failures some more, but I don't think they are related to the change to exclusiveAccess.dirs. Issues:   https://bugs.openjdk.java.net/browse/JDK-8220295   https://bugs.openjdk.java.net/browse/JDK-8220242 At this point just looking for feedback, if this is a reasonable direction to deal with the intermittent timeouts with theses tests to reduce the concurrency with other attaching tests.