Thanks, Chris.

On 4/2/19 2:16 PM, Chris Plummer wrote:
Changes to CollectedHeap.java and ObjectHeap.java look fine. One minor nit. Please fix the indent of line 258 in ObjectHeap.java:

  257         while (handle.lessThan(top)) {
  258         Oop obj = null;
  259           // Raw pointer walk
  260           handle = handle.addOffsetToAsOopHandle(heap.oopOffset());

I will fix it before push.

-Zhengyu


thanks,

Chris

On 4/1/19 6:26 AM, Zhengyu Gu wrote:
Hi,

May I get review from serviceability? as it has minor changes in shared code (CollectedHeap.java and ObjectHeap.java)


Thanks,

-Zhengyu


On 3/14/19 11:37 AM, Zhengyu Gu wrote:
Please review this patch that provides best-effort implementation of live regions iteration for Shenandoah GC.

There are minor changes in shared code, to adjust oop offset from base of allocation cell.

Bug: https://bugs.openjdk.java.net/browse/JDK-8220602
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220602/webrev.00/index.html


Test:
   hotspot_gc_shenandoah
   hotspot_serviceability
   vmTestbase/nsk/jdb
   manual test: jhsdb hsdb
   on Linux x64

   Passed submit test.


Thanks,

-Zhengyu



Reply via email to