Hi Jc,
Thank you a lot for the review!
The initial plan was to remove after a couple of releases.
But there was an external suggestion to hit at least one LTS release
before removal.
So, the decision about exact release for removal is still on the table.
We still collect information about tools that need this flag.
Thanks,
Serguei
On 4/17/19 11:17 AM, Jean Christophe Beyler wrote:
Hi Serguei,
Looks good to me. When are we aiming to deprecate it entirely? Do we
have an idea of the time frame?
Thanks,
Jc
On Tue, Apr 16, 2019 at 4:41 AM [email protected]
<mailto:[email protected]> <[email protected]
<mailto:[email protected]>> wrote:
Please, review the fix of:
https://bugs.openjdk.java.net/browse/JDK-8192936
Webrev (fix from Coleen):
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8192936-redef-add-delete.1/
<http://cr.openjdk.java.net/%7Esspitsyn/webrevs/2019/8192936-redef-add-delete.1/>
I've already reviewed and updated the webrev with my suggestions.
Reviewed and approved CSR:
https://bugs.openjdk.java.net/browse/JDK-8221528
Summary:
The fix introduces new VM option
-XX:AllowRedefinitionToAddOrDeleteMethods
for compatibility with previous releases.New option enables old
behavior
and allows the JVM TI RedefineClasses and RetransformClasses to
add/delete
private static and private final instance methods in the new
class versions.
Without this option the old behavior is disabled.
New option is deprecated right away.
The plan is to keep this option for several releases to allow
customers
(tool vendors) to remove dependency on old behavior from their
tools.
Testing:
Added new test to verify that class redefinitions which add or
delete methods
return expected JVMTI error codes:
test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestAddDeleteMethods.java
Several jvmti, com/sun/jdi and java/lang/instrument tests which
need old behavior are updated to use new flag.
Run locally on Linux-x64 the following test suites in release
and fastdebug mode:
- open/test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/
- vmTestbase_nsk_jvmti
- vmTestbase_nsk_jdi
- vmTestbase_nsk_jdb
- vmTestbase_nsk_jdwp
- jdk_jdi
- jdk_instrument
Submission of corresponding mach5 jobs is in progress.
Thanks,
Serguei
--
Thanks,
Jc
