Thank you, Serguei and JC, for reviewing this change!
Best regards, Daniil From: Jean Christophe Beyler <[email protected]> Date: Thursday, April 25, 2019 at 5:32 PM To: Serguei Spitsyn <[email protected]> Cc: Daniil Titov <[email protected]>, OpenJDK Serviceability <[email protected]> Subject: Re: RFR: 8222749: vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "eventSet1.size() != 3 :: 2" Hi Daniil, It looks good to me too :) Jc On Thu, Apr 25, 2019 at 5:21 PM <[email protected]> wrote: Hi Daniil, Looks good. Thanks, Serguei On 4/25/19 4:34 PM, Daniil Titov wrote: > Please review the change that fixes this test when it is run with Graal on. > > The test starts the debugee, creates multiple thread start requests, tells > the debuggee to start a new thread, and listens for the thread start events > received. If the number of the received thread start events doesn't match the > number of created thread start requests the test fails. The problem here is > that with Graal on, sometimes, the test receives events caused by the start > of "HotSpotGraalManagement Bean Registration" thread. > > The fix ensures that a thread filter is added for all created thread start > requests to ignore events caused by the threads not related to the test. > > Webrev: http://cr.openjdk.java.net/~dtitov/8222749/webrev.01/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8222749 > > Thanks, > Daniil > > -- Thanks, Jc
