tests on submit repo have been passed (mach5-one-ysuenaga-JDK-8223665-20190510-0157-2376640)
Could you review the CSR? > CSR: https://bugs.openjdk.java.net/browse/JDK-8223666 Yasumasa 2019年5月10日(金) 10:20 Yasumasa Suenaga <[email protected]>: > > Hi, > > Osamu, your change looks good to me. > I will sponsor you. > > David, I filed this issue and requested to CSR: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8223665 > CSR: https://bugs.openjdk.java.net/browse/JDK-8223666 > > I uploaded webrev. I will push it to submit repo. > > http://cr.openjdk.java.net/~ysuenaga/JDK-8223665/webrev.00/ > > > Thanks, > > Yasumasa > > > On 2019/05/10 7:30, David Holmes wrote: > > Hi, > > > > This will need a bug filed and a corresponding CSR request. I suspect > > that historically the form of this command was done to match other tools. > > > > > > Thanks, > > David > > > > On 9/05/2019 6:33 pm, ?? ? wrote: > >> Hi all, > >> > >> I want to use `jhsdb debugd` on my laptop. > >> However debugd mode has different options from other modes. > >> I think debugd should have same options like other modes. > >> > >> For example, `jhsdb debugd <pid>` should be `jhsdb debugd --pid <pid>`. > >> Also I added `--serverid` option for serverid. > >> > >> I attached a patch for this enhancement. > >> This patch passes serviceability/sa jtreg tests. > >> > >> Testcase for debugd is available as > >> serviceability/sa/sadebugd/SADebugDTest.java . > >> However it has been disabled by JDK-8163805. > >> It will be fixed by Yasumasa Suenaga (ysuenaga) after my proposal has been > >> merged. > >> > >> Could you help? I want to contribute it. I need a sponsor. > >> (My company has signed to OCA (NTT Comware Corporation)) > >> > >> Thanks, > >> > >> Osamu > >>
