Re: RFR (XS) 8223779: Build failure after 8223040 (Add a AsyncGetCallTrace test)

Mon, 13 May 2019 13:37:45 -0700

I can do that.

Chris


On 5/13/19 1:33 PM, Jean Christophe Beyler wrote:
Hi all,

Submit repo seems down, could someone test it via mach1 testing please?


(Or I can wait until submit repo comes back online for me :-))

Thanks!
Jc

From: [email protected] <[email protected]>
Date: Mon, May 13, 2019 at 1:03 PM
To: Chris Plummer, Jean Christophe Beyler, OpenJDK Serviceability
Cc: Aleksey Shipilev

On 5/13/19 09:21, Chris Plummer wrote:
Hi Jc,

+1

Thanks,
Serguei


Hi JC,

Your fix is consistent with the one done for https://bugs.openjdk.java.net/browse/JDK-8169261, so thumbs up.

thanks,

Chris

On 5/13/19 8:18 AM, Jean Christophe Beyler wrote:
Hi all,

Here is a small patch for fixing a fastdebug linking error:

Diff is:

diff -r 85ccac8a8c13 make/test/JtregNativeHotspot.gmk
--- a/make/test/JtregNativeHotspot.gmk  Mon May 13 16:43:47 2019 +0200
+++ b/make/test/JtregNativeHotspot.gmk  Mon May 13 08:13:11 2019 -0700
@@ -864,7 +864,7 @@
     BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exestack-gap := -ljvm -lpthread
     BUILD_TEST_exeinvoke_exeinvoke.c_OPTIMIZATION := NONE
     BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exeFPRegs := -ldl
-    BUILD_HOTSPOT_JTREG_LIBRARIES_LDFLAGS_libAsyncGetCallTraceTest := -ldl
+    BUILD_HOTSPOT_JTREG_LIBRARIES_LIBS_libAsyncGetCallTraceTest := -ldl
 else
   BUILD_HOTSPOT_JTREG_EXCLUDE += libtest-rw.c libtest-rwx.c libTestJNI.c \
       exeinvoke.c exestack-gap.c libAsyncGetCallTraceTest.cpp

Important note: it passes with or without this patch on my dev machine but  Aleksey Shipilev saw the failure and saw that the patch helps. So I think this should be done; I'm sending it to the submit-repo at the same time.

Thanks,
Jc





--

Thanks,
Jc


Reply via email to