|
Hi Jc,
I'm Okay with this fix in general modulo some suggestion from
Chris below.
On 5/15/19 18:49, Chris Plummer wrote:
Hi JC,
Looks like s390 is also not supported. Do we know for usre if it
is implemented on other architectures, like aarch64? I wouldn't
necessarily rely on the lack of a negative comment in
JavaThread::pd_get_top_frame_for_signal_handler() to determine
support. Maybe the test should list supported platforms rather
than unsupported ones.
I like the suggestion above.
It is better to list what is supported now.
Also, why does the test currently
require linux?
My guess is that Jc does not have other platforms to check it on.
Probably, it is Okay for now to keep it this way.
Then we could file an RFE, check if ASGCT tests work Okay on other
OS'es and relax this limitation.
Thanks,
Serguei
Chris
On 5/15/19 6:01 PM, Jean Christophe Beyler wrote:
Hi all,
Could I get a review that restricts the test to not run
on PPC64/IA64 please?
Bug: https://bugs.openjdk.java.net/browse/JDK-8224020
I also moved NULL -> RTLD_DEFAULT as the man
page on linux does not specify the behavior of
passing NULL.
Thanks,
Jc
|
