Hi Serguei, thanks for the review.
Best regards, Martin From: serviceability-dev <serviceability-dev-boun...@openjdk.java.net> On Behalf Of serguei.spit...@oracle.com Sent: Dienstag, 21. Mai 2019 05:55 To: Jean Christophe Beyler <jcbey...@google.com>; Lindenmaier, Goetz <goetz.lindenma...@sap.com> Cc: serviceability-dev@openjdk.java.net Subject: Re: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace Hi Martin, LGTM++ Thanks, Serguei On 5/20/19 09:34, Jean Christophe Beyler wrote: Hi Martin, Looks good to me too :) Jc On Mon, May 20, 2019 at 8:56 AM Lindenmaier, Goetz <goetz.lindenma...@sap.com<mailto:goetz.lindenma...@sap.com>> wrote: LGTM Goetz! > -----Original Message----- > From: Doerr, Martin > Sent: Montag, 20. Mai 2019 17:49 > To: Lindenmaier, Goetz > <goetz.lindenma...@sap.com<mailto:goetz.lindenma...@sap.com>>; serviceability- > d...@openjdk.java.net<mailto:d...@openjdk.java.net>; JC Beyler > <jcbey...@google.com<mailto:jcbey...@google.com>>; Volker Simonis > (volker.simo...@gmail.com<mailto:volker.simo...@gmail.com>) > <volker.simo...@gmail.com<mailto:volker.simo...@gmail.com>> > Subject: RE: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace > > Hi Götz, > > thanks for reviewing it so quickly. > > Thanks for pointing me to the obsolete comment. I've also fixed in on PPC64 > and also removed a redundant assertion on PPC64: > http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr > ev.01/ > > I haven't used async profiler, but I've ran JTREG tests for hotspot runtime on > linux PPC64 (Big and Little Endian) and s390 and all ones have passed. > > Best regards, > Martin > > > -----Original Message----- > From: Lindenmaier, Goetz > Sent: Montag, 20. Mai 2019 17:36 > To: Doerr, Martin <martin.do...@sap.com<mailto:martin.do...@sap.com>>; > serviceability- > d...@openjdk.java.net<mailto:d...@openjdk.java.net>; JC Beyler > <jcbey...@google.com<mailto:jcbey...@google.com>>; Volker Simonis > (volker.simo...@gmail.com<mailto:volker.simo...@gmail.com>) > <volker.simo...@gmail.com<mailto:volker.simo...@gmail.com>> > Subject: RE: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace > > Hi Martin, > > the changes look good. > > Please fix this comment: > // Forte Analyzer AsyncGetCallTrace profiling support is not implemented on > Linux/S390x. > I guess it's no more true. No new webrev needed. > > Did you verify that the test works, or did you also try > async with the VM on ppc? > > Best regards, > Goetz. > > > -----Original Message----- > > From: Doerr, Martin > > Sent: Montag, 20. Mai 2019 17:32 > > To: > > serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>; > > JC Beyler <jcbey...@google.com<mailto:jcbey...@google.com>>; > > Volker Simonis (volker.simo...@gmail.com<mailto:volker.simo...@gmail.com>) > > <volker.simo...@gmail.com<mailto:volker.simo...@gmail.com>>; > > Lindenmaier, Goetz > > <goetz.lindenma...@sap.com<mailto:goetz.lindenma...@sap.com>> > > Subject: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace > > > > Hi, > > > > > > > > please review my change which allows usage of AsyncGetCallTrace on PPC64 > > and s390. > > > > > > > > Webrev: > > > > > http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr > > ev.00/ > > > > > > > > Bug with more background information: > > > > https://bugs.openjdk.java.net/browse/JDK-8224230 > > > > > > > > Best regards, > > > > Martin > > > > -- Thanks, Jc
