Hi Christoph,
On 27/05/2019 6:24 pm, Langer, Christoph wrote:
Hi David,
ok, as for the general need for a CSR.
There's some history here: When the initial change was made for that feature
(delayed start of debugging, [0]), we missed going through the CSR process.
After Alan had discovered this, Ralf created a CSR [1] to retroactively review
this item. However, nothing happened on it yet on the review side. Now Ralf
also has a (reviewed) code change regarding an additional jcmd to get the
listen address of the debugger [2], [3]. And now there's also this item to
update the required permission.
I'm wondering whether we should use the CSR 8223456 to discuss all of this
context... Do you think that's appropriate?
That's a bit of a mess :( The thing is that this code has been released
in 12 and is now being changed in 13 - so that's the compatibility risk
I want to see assessed for this issue, not the original enhancement request.
So I think the retrospective CSR needs to be handled independently and
based on what actually got pushed in 12. Then a separate CSR for this
issue. But feel free to raise on [email protected]
David
-----
Thanks
Christoph
[0] https://bugs.openjdk.java.net/browse/JDK-8214892
[1] https://bugs.openjdk.java.net/browse/JDK-8223456
[2] https://bugs.openjdk.java.net/browse/JDK-8223065
[3]
https://mail.openjdk.java.net/pipermail/serviceability-dev/2019-April/027833.html
-----Original Message-----
From: serviceability-dev <[email protected]> On
Behalf Of David Holmes
Sent: Samstag, 25. Mai 2019 01:06
To: Schmelter, Ralf <[email protected]>; serviceability-
[email protected]
Subject: Re: RFR (S) 8224673: Adjust permission for delayed starting of
debugging
Hi Ralf,
This will need a CSR request to change the permission.
Thanks,
David
On 24/05/2019 10:05 pm, Schmelter, Ralf wrote:
Please review this small change. It changes the permission needed to
delayed start the debugging (when enabled with onjcmd=y) via a
diagnostic mbean.
webrev:
http://cr.openjdk.java.net/~rschmelter/webrevs/8224673/webrev.0/
bugreport: https://bugs.openjdk.java.net/browse/JDK-8224673
Best regards,
Ralf
