Re: 8217348: assert(thread->is_Java_thread()) failed: just checking

[David Holmes]

On 15/06/2019 10:06 am, Daniil Titov wrote:

Hi Serguei,

The discovery was made by David Holmes. Thank you, David, a lot!

:) Wish I'd spotted it the first time round.

Fix looks good.

Thanks,
David

Best regards,
Daniil

On 6/14/19, 5:01 PM, "serguei.spit...@oracle.com" <serguei.spit...@oracle.com> 
wrote:

     Hi Daniil,

Great discovery!

     The fix looks good to me.

Thanks,

     Serguei

On 6/14/19 4:56 PM, Daniil Titov wrote:

     > Please review the change that fixes an intermittent issue.
     >
     > The problem here is that a bitwise-AND (&) operator was used in the condition 
instead of a logical AND operator (&&).
     > As a result pending_thread->is_thread_fully_suspended() is always 
evaluated regardless of the value of at_safepoint variable.
     >
     > Webrev: http://cr.openjdk.java.net/~dtitov/8217348/webrev.01/
     > Bug: https://bugs.openjdk.java.net/browse/JDK-8217348
     >
     > Thanks!
     > --Daniil
     >
     >