Hi Serguei,
The updates to the heading levels all looks fine.
However the tables in the generated output look broken - they all have
empty "header" rows with incorrect columns and no text. ??
David
On 2/07/2019 11:08 am, [email protected] wrote:
Hi David,
On 7/1/19 14:15, David Holmes wrote:
Hi Serguei,
On 2/07/2019 4:57 am, [email protected] wrote:
Please, review a doc issue fix for:
https://bugs.openjdk.java.net/browse/JDK-8226596
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.1/
The updated JDWP protocol page:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/jdwp-protocol.html
Summary:
The change is to replace the 'navigation' attribute with the <nav>
element.
That looks fine.
With this fix, the Axe reports one issue only:
"Page must contain a level one heading".
I'm not sure what to do to workaround this.
The page was not initially designed to have a level one heading.
It has to be normally used in the context of enclosed page which
haswith a level one heading.
Not sure what you mean by an "enclosed page". Where can I see this in
context?
Sorry, I wanted to say "enclosing page".
We had a private chat with David on this.
The decision is to add a heading one to the page and align all other
headings with it.
New webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.2/
I've updated the file:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/jdwp-protocol.html
The Axe does not report errors anymore.
Thanks,
Serguei
Thanks,
David
-----
Testing:
Verified with the Axe plugin (add-on) for Mozilla Firefox browser.
Asked Alex M. to double-check this, and his Axe reported no errors.
Thanks,
Serguei
