Hi Alex,
I think the calls to GetLastError() should be in the else clauses, just
before or as part of the log_error() statements. Otherwise you are
making the GetLastError() calls even when there is no error.
thanks,
Chris
On 7/3/19 1:59 PM, Alex Menkov wrote:
Hi all,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8227124
This is subtask of JDK-8221512: Failed to complete jcmd operation
'[error][attach] could not open pipe \\.\pipe\javatool-708501419 to
send result of operation jcmd'
To fix issues with "could not open pipe" error, additional info is
required, the change adds logging of system error.
webrev:
http://cr.openjdk.java.net/~amenkov/jdk14/openPipeErrorLog/webrev/
--alex
