Hi Ralf,
The indent is off for the following in BasicJStackTest.java:
39 private static String markerName = "markerName" +
"\u00e4\u0bb5".repeat(10_000);
Also you need to update the copyright date for BasicJStackTest.java,
JInfo.java ,and JStack.java.
Otherwise looks good. No need for another weberv.
thanks,
Chris
On 7/19/19 6:33 AM, Schmelter, Ralf wrote:
Hi David,
thanks for the review.
Not sure why you chose a 8K
buffer when existing codes uses 256 chars?
I took it from the Reader.transferTo() method. But I've changed it to back to
256.
There would ideally have been a regression test written for JDK-8222491
to demonstrate the conversion problem.
I've added a test which shows the problem for jcmd. And I've modified the basic
jstack test to test for the problem too. For jinfo testing would be much
harder, since it either prints already sanitized output (system properties) or
values which depend on the platform encoding (flags and command line).
Here is the update webrev:
http://cr.openjdk.java.net/~rschmelter/webrevs/8227868/webrev.3/
Best regards,
Ralf
