That sounds like a better approach to me.
thanks,
Chris
On 8/8/19 4:33 PM, dean.l...@oracle.com wrote:
This is the kind of failure that is expected to go away with libgraal.
You can add the tests to the Graal-specific problem list (see
JDK-8196611) and they should be re-enabled with libgraal (see
JDK-JDK-8207267).
dl
On 8/8/19 10:21 AM, Chris Plummer wrote:
Hi Daniil,
My only objection is at some point it seems we need to be able to run
these tests with graal (and other tests that have been disabled due
to graal) because graal might be the only compiler, and we'll lose
test coverage without these tests. Currently we have 260 jtreg tests
disabled due to graal. I'm not sure to what extent they are waiting
on graal fixes or otherwise have a bug filed to eventually fix them.
Would be nice if we had a process in place to make sure these issues
are eventually addressed. That fact that tests that exhaust memory in
general seem to be incompatible with graal would to be the bigger
issue that needs to be addressed.
thanks,
Chris
On 8/7/19 3:38 PM, Daniil Titov wrote:
Please review the change that fixes the failing tests when running
with Graal. The issue originally
included several vmTestbase/nsk/jdi tests but only 2 of them still
fail:
-
vmTestbase/nsk/jdi/VirtualMachine/instanceCounts/instancecounts003/instancecounts003.java
-
vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java
The problem with these two tests is that they consume all memory to
force the class unloading that
results in the exception during JVMCI compiler initialization and
the test failure.
The fix filters these tests out to not run with Graal compiler.
Webrev: http://cr.openjdk.java.net/~dtitov/8195600/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8195600
Thanks,
Daniil
