On 14/08/2019 03:28, Chris Plummer wrote: > On 8/13/19 6:26 PM, Nick Gasson wrote: >> Hi Chris, >> >>> The changes look good, although I think the new file should go in the >>> serviceability/sa test directory, unless you think this is a generally >>> useful class that might be used by tests outside of the sa. >>> >> >> The new file is under test/hotspot/jtreg/serviceability/sa/ - the same >> directory as ClhsdbFindPC.java - did you mean somewhere else? >> >> Thanks, >> Nick >> > Oh, sorry. For some reason I thought it was in the lib directory with > LingeredApp. Yes, it's good the way it is. I'm still happy with this patch to go in after these changes.
regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander