Thumbs up. This is a trivial fix so only requires a single (R)eviewer.

Dan


On 9/5/19 11:01 AM, Langer, Christoph wrote:

Hi,

please review exclusion of serviceability/sa/TestInstanceKlassSize.java for linux on the ppc platforms.

The test was probably ever failing on these platforms. Martin has done some initial analysis of the problem. I’ve opened https://bugs.openjdk.java.net/browse/JDK-8230664 to track resolution (@Martin: can you please add some more technical detail to the bug? Thanks.)

The resolution will probably take some time and the platforms are not tier1, so we shall exempt the test from being executed for the time being.

This is the bug: https://bugs.openjdk.java.net/browse/JDK-8230666 <https://bugs.openjdk.java.net/browse/JDK-8230666>

This is the patch:

diff -r 397b97fb989c test/hotspot/jtreg/ProblemList.txt

--- a/test/hotspot/jtreg/ProblemList.txt        Thu Sep 05 16:50:18 2019 +0200

+++ b/test/hotspot/jtreg/ProblemList.txt        Thu Sep 05 16:54:36 2019 +0200

@@ -128,7 +128,7 @@

serviceability/sa/TestG1HeapRegion.java 8193639 solaris-all

serviceability/sa/TestHeapDumpForInvokeDynamic.java 8193639 solaris-all

serviceability/sa/TestHeapDumpForLargeArray.java 8193639 solaris-all

-serviceability/sa/TestInstanceKlassSize.java 8193639 solaris-all

+serviceability/sa/TestInstanceKlassSize.java 8193639,8230664 solaris-all,linux-ppc64le,linux-ppc64

serviceability/sa/TestInstanceKlassSizeForInterface.java 8193639 solaris-all

serviceability/sa/TestIntConstant.java 8193639,8211767 solaris-all,linux-ppc64le,linux-ppc64

serviceability/sa/TestJhsdbJstackLock.java 8193639 solaris-all

Thanks

Christoph


Reply via email to