Thanks for the quick reviews!
Chris
On 9/27/19 2:49 PM, Hohensee, Paul wrote:
+1.
Paul
On 9/27/19, 2:06 PM, "serviceability-dev on behalf of serguei.spit...@oracle.com"
<serviceability-dev-boun...@openjdk.java.net on behalf of serguei.spit...@oracle.com>
wrote:
Hi Chris,
It looks good.
Thanks,
Serguei
On 9/27/19 1:29 PM, Chris Plummer wrote:
> Hello,
>
> Please review the following:
>
> https://bugs.openjdk.java.net/browse/JDK-8231287
> http://cr.openjdk.java.net/~cjplummer/8231287/webrev.00
>
> Basically no longer have jmap consume and hide exceptions that are
> thrown, and have all tools catch and print any exception that is
> propagated to Tools.execute(). The CR contains more details.
>
> Tested with the following:
>
> :hotspot_serviceability
> :jdk_svc
> :vmTestbase_nsk_jdi
> :vmTestbase_nsk_jvmti
> :vmTestbase_nsk_jdwp
> :vmTestbase_nsk_jdb
>
> thanks,
>
> Chris
>