On 9/27/19 1:12 PM, Severin Gehwolf wrote: > The proposed patch handles serialized null scopes similar to the > hotspot side of things, by returning a null scope. CompiledVFrame > already deals with null scopes when in debugging mode. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196969 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196969/03/webrev/ > > Testing: tier 1 tests on Linux x86_64 (release/fastdebug). jdk-submit > and ran various reproducer tests including 1000 interations of the > added regression test. All pass.
Indeed, this is how all of the code in ScopeDesc handles it, which looks right. I do wonder if there may be other places which fail to handle null scopes, though. OK. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
