Hi Chris, Thanks for the review, do you want me to cover this with regression test? I suspect that it was not required.
Thanks, Fairoz -----Original Message----- From: Chris Plummer Sent: Thursday, October 3, 2019 9:55 PM To: Fairoz Matte <fairoz.ma...@oracle.com>; serviceability-dev <serviceability-dev@openjdk.java.net> Subject: Re: RFR (S) 8216352: SA: ClhsdbLauncher should throw errors on Unrecognized commands Hi Fairoz, I think it looks fine. I guess this implies that we don't have a test that verifies that we get "Unrecognized command." if a bad command is passed, in which case a different approach would be needed (perhaps a flag that says to verify that we get "Unrecognized command." instead of not get it). thanks, Chris On 10/3/19 6:47 AM, Fairoz Matte wrote: > Hi, > > Please review a tiny change to handle unrecognized command options for > ClhsdbLauncher test. > This patch is already proposed by Gary Adams in comments section. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8216352 > Webrev: http://cr.openjdk.java.net/~fmatte/8216352/webrev.00/ > > Thanks, > Fairoz
