On 10/8/19 9:25 AM, David Holmes wrote:
Hi Per,
Thanks for taking a look!
On 8/10/2019 4:56 pm, Per Liden wrote:
Hi David,
On 10/8/19 3:58 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8231737
webrev: http://cr.openjdk.java.net/~dholmes/8231737/webrev/
Stylistic code cleanup of JvmtiRawMonitor code as previously promised:
Very nice clean up! But when changing the names, may I suggest that we
follow the HotSpot style-guide naming convention.
All fixed! webrev updated in place.
Looks good.
thanks,
Per
Thanks,
David
-----
- Self -> self
- SimpleX -> simpleX
Should be simple_x
- Contended -> contended
- Node -> node
- TState -> tState (variable name)
Should be _tstate or _t_state.
- _WaitSet -> _waitSet
Should be _wait_set.
- _EntryList -> _entryList;
Should be _entry_list.
cheers,
Per
- All -> all
- remove extra space before ( in function calls
- remove extra space before ;
- remove extra space before ++ and --
- add spaces around binary operators
- use { } on all blocks
- use one statement per line.
- fix indent and alignment (ie remove artificial alignment)
Probably simplest to look at new code and see if it looks okay rather
than trying to spot each individual change. :)
Thanks,
David
