> I kept the 128M That's good.
Cheers, Richard. -----Original Message----- From: Per Liden <per.li...@oracle.com> Sent: Wednesday, October 9, 2019 8:24 PM To: Reingruber, Richard <richard.reingru...@sap.com>; hotspot-compiler-dev <hotspot-compiler-...@openjdk.java.net> Cc: serviceability-dev@openjdk.java.net Subject: Re: RFR: 8232056: GetOwnedMonitorInfoWithEATest.java fails with ZGC: Heap too small Thanks for reviewing, Richard. I kept the 128M, since that was what I ran through testing, and I'd like to push this as soon as possible since it's causing noise in our CI. If someone wants to remove the -Xmx128M, feel free to file a follow up. However, note that the test might then consume more memory, since the default -Xmx might be larger than 128M in some environments/configurations. cheers, Per On 10/9/19 4:04 PM, Reingruber, Richard wrote: > Hi Per, > > Sorry about the problem. Your change looks good to me, I'm not a reviewer > though. > > Alternatively you can just remove the lines that set -Xmx (and -Xms). The > lines are not needed in these tests (copied from other tests). I've tried > that successfully just now. > > Thanks, Richard. > > -----Original Message----- > From: Per Liden <per.li...@oracle.com> > Sent: Mittwoch, 9. Oktober 2019 15:20 > To: hotspot-compiler-dev <hotspot-compiler-...@openjdk.java.net> > Cc: Reingruber, Richard <richard.reingru...@sap.com>; > serviceability-dev@openjdk.java.net > Subject: RFR: 8232056: GetOwnedMonitorInfoWithEATest.java fails with ZGC: > Heap too small > > The newly added: > > GetOwnedMonitorInfoWithEATest.java > GetOwnedMonitorStackDepthInfoWithEATest.java > > fail when run with ZGC as they set -Xmx to 32M which is too. Bumping to > 128m. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8232056 > Webrev: http://cr.openjdk.java.net/~pliden/8232056/webrev.0 > > /Per >
