Re: RFR: 8232084: HotSpot build failed with GCC 9.2.1

Wed, 09 Oct 2019 23:33:08 -0700

Hi Yasumasa,

The fix in src/hotspot/cpu/x86/macroAssembler_x86.hpp looks Okay.

But I don't understand why you need this fix in src/hotspot/share/services/diagnosticArgument.cpp ?: 
       char* buf = NEW_RESOURCE_ARRAY(char, len + 1);
-      strncpy(buf, str, len);
+      strncpy(buf, str, len + 1);
       buf[len] = '\0';
The buf[len] is set to '\0' anyway.

Thanks,
Serguei


On 10/9/19 22:55, Yasumasa Suenaga wrote:
Hi all,

Please review this change:

  JBS: https://bugs.openjdk.java.net/browse/JDK-8232084
  webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8232084/webrev.00/


I tried to build OpenJDK on Fedora 30 x64 with GCC 9.2.1, but it was failed in
macroAssembler_x86.hpp and diagnosticArgument.cpp .
(Please see JBS for details)

This change has passed tests on submit repo.


Thanks,

Yasumasa (ysuenaga)

Reply via email to