Lgtm. Thanks,
Paul On 10/18/19, 4:28 PM, "Yasumasa Suenaga" <[email protected]> wrote: Hi Paul, After this change, we can see JNI call as below: ``` "process reaper" #14 daemon prio=10 tid=0x00007f12ec4b6000 nid=0x56a3 runnable [0x00007f12d009c000] java.lang.Thread.State: RUNNABLE JavaThread state: _thread_in_native 0x00007f12f43f5596 __waitpid + 0x56 0x00007f12dc5c134d java.lang.ProcessHandleImpl.waitForProcessExit0(long, boolean) + 0xed (Native method) 0x00007f12d579730c * java.lang.ProcessHandleImpl$1.run() bci:8 line:138 (Compiled frame) ``` Thanks, Yasumasa On 2019/10/19 1:59, Hohensee, Paul wrote: > What is the output with your patch? > > Thanks, > > Paul > > On 10/18/19, 1:38 AM, "serviceability-dev on behalf of Yasumasa Suenaga" <[email protected] on behalf of [email protected]> wrote: > > Hi all, > > Please review this change. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8232592 > webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8232592/webrev.00/ > > I run `jhsdb jstack --mixed` to JShellToolProvider process, then I saw <Unknown compiled code> > in the stack as below: > > ``` > "process reaper" #13 daemon prio=10 tid=0x00007f959c328000 nid=0x1285 runnable [0x00007f9578025000] > java.lang.Thread.State: RUNNABLE > JavaThread state: _thread_in_native > 0x00007f95a27c5596 __waitpid + 0x56 > 0x00007f958c601d79 <Unknown compiled code> > 0x00007f9585c5b4ac * java.lang.ProcessHandleImpl$1.run() bci:8 line:138 (Compiled frame) > ``` > > 0x7f958c601d79 is native method. jstack mixed mode should handle it. > This patch passed all tests on submit repo (mach5-one-ysuenaga-JDK-8232592-20191018-0600-6011163). > > > Thanks, > > Yasumasa > >
