Hi Alex,

The fix itself looks Okay.
Minor: replace in the comment: "compiler don't drop" => "compiler doesn't drop".

However, we still have to reach a consensus on how we treat this issue (as Chris already commented).

Thanks,
Serguei


On 11/8/19 15:22, Alex Menkov wrote:
Hi all,

Please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8215196
webrev:
http://cr.openjdk.java.net/~amenkov/jdk14/popframe_args/webrev/

Currently PopFrame is disabled with JVMCI by [1], so for testing I reverted [1] changes.

[1] https://bugs.openjdk.java.net/browse/JDK-8218025

--alex

Reply via email to