Hi Serguei, Thank you for your review and discussion around this issue.
-- Igor > On Nov 18, 2019, at 3:56 PM, [email protected] wrote: > > Hi Igor, > > Looks good. > Thank you for taking care about this! > > Thanks, > Serguei > > > On 11/15/19 23:47, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8233462/webrev.00 >>> 33 lines changed: 1 ins; 14 del; 18 mod; >> Hi all, >> >> could you please review this small fix for tmtools testlibrary? >> tmtools tests are believed to fail due to a deadlock-like situation b/w main >> test process and tmtools process: >> (from JBS) >>> it seems these tests attach jstat to the main test process, the same >>> process which reads the tool's stdout/stderr, so there is a possibility >>> that this will deadlock: jstat-process produces more output than the buffer >>> can hold, so it blocks till someone (the main process reads it), while the >>> main process waits till jstat completes. >> the patch changes serviceability/tmtools/share/common library (used by all >> serviceability/tmtools) to redirect tmtool's stdout and stderr into files >> instead of using jdk.test.lib.process.OutputAnalyzer; I've also added a bit >> of diagnostic output, so it will be easier to analyze future failures. >> >> webrev: http://cr.openjdk.java.net/~iignatyev//8233462/webrev.00 >> JBS: https://bugs.openjdk.java.net/browse/JDK-8233462 >> testing: >> - serviceability/tmtools on windows-x64,linux-x64,macosx-x64,solaris-sparcv9 >> - serviceability/tmtools 100 times on linux-x64-debug w/ '-Xcomp -ea -esa >> -XX:+TieredCompilation -XX:+DeoptimizeALot' (most of failures have been seen >> on this configuration) >> >> Thanks, >> -- Igor >
