Please, review a fix for test bug:
https://bugs.openjdk.java.net/browse/JDK-8221372 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8221372-jvmti-thread-state.1/ Summary: The test timeouts always happen with the JFR recording and mostly on windows. I was not able to reproduce this with mach5 100 runs though. However, I think the issue is with the MethodEnter/MethodExit events that are set globally. It is not only ~20 times slower but also impacts all JFR methods working in background. The fix includes the following changes: - the MethodEnter/MethodExit events are removed - the code is refactored to implement repeating fragments as functions - minimal tracing is added to help with analysis of timeouts if they remain Testing: Tested the vmTestbase/nsk/jvmti/GetThreadState/thrstat001 test with mach5 100 runs. Thanks, Serguei |
- RFR(S): 8221372: Test vmTestbase/nsk/jvmti/GetT... serguei.spit...@oracle.com
- Re: RFR(S): 8221372: Test vmTestbase/nsk/j... Chris Plummer
- Re: RFR(S): 8221372: Test vmTestbase/n... Alex Menkov
- Re: RFR(S): 8221372: Test vmTestba... serguei . spitsyn
- Re: RFR(S): 8221372: Test vmTestbase/n... serguei . spitsyn
- Re: RFR(S): 8221372: Test vmTestba... Chris Plummer
- Re: RFR(S): 8221372: Test vmTe... serguei . spitsyn