On 12/17/19 3:14 AM, Per Liden wrote:
Hi Coleen,
The "nmethod entry barrier"-part looks good to me. Just one minor nit,
maybe JvmtiDeferredEventQueue::run_nmethod_entry_barrier should have
an "s" on it (i.e.
JvmtiDeferredEventQueue::run_nmethod_entry_barriers) since it loops
over all entries in the queue?
I changed both entries in jvmtiImpl.hpp to run_nmethod_entry_barriers to
avoid confusion on my part. It then calls the nmethod version that is
singular. Thanks for the suggestion of names.
But I don't dare to comment on the ServiceThread initialization order.
I moved it before the compiler and jvmti initialization, and jvmti won't
post events until the LIVE phase. I tried to be very careful!
Thanks,
Coleen
cheers,
Per
On 12/16/19 12:41 PM, coleen.phillim...@oracle.com wrote:
Summary: Start ServiceThread before compiler threads, and run nmethod
barriers for zgc before adding to the service thread queue, or
posting the events on the java thread queue.
See bug for description of the problems found with the new
Zombie.java test.
open webrev at
http://cr.openjdk.java.net/~coleenp/2019/8235829.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8235829
Ran tier1 all platforms, and tier2-8 testing, as well as rerunning
original test failure from bug
https://bugs.openjdk.java.net/browse/JDK-8173361.
Thanks,
Coleen
