Okay, thanks!
Serguei
On 12/18/19 20:43, Chris Plummer wrote:
We don't document the javascript support anywhere that I'm aware of.
The only way you would become aware of it is if after launching clhsdb
you did a "help" and saw the jsload and jseval commands, but that was
only when javascript initialization was working. When it's broken you
don't see these commands.
Chris
On 12/18/19 8:40 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
It looks okay.
I wonder if we have itdocumented anywhere.
Do we also need any doc cleanup?
Thanks,
Serguei
On 12/16/19 21:36, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8236062
http://cr.openjdk.java.net/~cjplummer/8236062/webrev.00/
Since SA javascript support is broken as described in [1]
JDK-8235594, and we'll likely remove it, I'd like to at least get it
disabled now. I'd like to get this into 14 mostly because I really
want to get [2] JDK-8234048 fixed in 14 because we'll start seeing
the clhsdb test failures on macos 10.14 and 10.15 more often over
the coming months as we deploy more macosx test hosts with those
versions. However, [2] JDK-8234048 is blocked by [3] JDK-8234277
(which improves error checking and failure output for the clhsdb
tests), and [3] JDK-8234277 is blocked by this CR because the
exceptions produced when javascript fails to initialize end up
cluttering the clhsdb test logs, even when the test passes (and is
misleading when the test fails).
Sorry about all the bug references and inter-dependencies. It's
taken a while myself to get my head wrapped around how I wanted to
approach fixing them all in a meaningful order.
thanks,
Chris
[1] https://bugs.openjdk.java.net/browse/JDK-8235594
[2] https://bugs.openjdk.java.net/browse/JDK-8234048
[3] https://bugs.openjdk.java.net/browse/JDK-8234277
