Hi Ralf, the enhacement you're proposing is useful I'd say. The enhancements it enables (streaming, compression) even more so.
Your change looks good to me. Note that I'm a JDK Committer not a Reviewer. Best regards, Richard. -----Original Message----- From: serviceability-dev <serviceability-dev-boun...@openjdk.java.net> On Behalf Of Schmelter, Ralf Sent: Montag, 16. Dezember 2019 13:28 To: Schmelter, Ralf <ralf.schmel...@sap.com>; Thomas Stüfe <thomas.stu...@gmail.com> Cc: OpenJDK Serviceability <serviceability-dev@openjdk.java.net>; hotspot-runtime-...@openjdk.java.net Subject: [CAUTION] RE: RFR (M) 8234510: Remove file seeking requirement for writing a heap dump I forgot to post the updated webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8234510/webrev.2/ In addition to the changes requested by Thomas, I also renamed the entries in the heap dump segment from entries to sub-records, since that is what they are called in the comment describing the format. Best regards, Ralf
