Thank you David, Daniel, and Serguei for reviewing this change!
Best regards,
Daniil
On 1/15/20, 10:45 PM, "serguei.spit...@oracle.com"
<serguei.spit...@oracle.com> wrote:
Hi Daniil,
LGTM++
Thanks,
Serguei
On 1/15/20 14:28, David Holmes wrote:
> +1
>
> David
>
> On 16/01/2020 4:41 am, Daniel Fuchs wrote:
>> Hi Daniil,
>>
>> That looks fine to me.
>>
>> best regards,
>>
>> -- daniel
>>
>> On 15/01/2020 18:15, Daniil Titov wrote:
>>> Please review a change [1] that fixes a deadlock issue [2] in
>>> sun.tools.jconsole.Worker class.
>>>
>>> There is no need in guarding "stopped" flag by a lock. The fix
>>> removes this excessive locking and
>>> instead makes the flag volatile.
>>>
>>> Mach5 tier1-tier3 tests passed.
>>>
>>> [1] Webrev : http://cr.openjdk.java.net/~dtitov/8236873/webrev.01/
>>> [2] Issue: https://bugs.openjdk.java.net/browse/JDK-8236873
>>>
>>> Best regards,
>>> Daniil
>>>
>>>
>>
