Re: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element

[serguei.spit...@oracle.com]

Hi Martin, It looks good to me. Thanks, Serguei On 2/24/20 05:51, Doerr, Martin wrote: Hi,   reposting on serviceability-dev (was core-libs-dev before).   Bug: https://bugs.openjdk.java.net/browse/JDK-8239856   Webrev: http://cr.openjdk.java.net/~mdoerr/8239856_win32_long_double_align/webrev.00/   Thanks for the review, Thomas!   Best regards, Martin     From: Thomas Stüfe <thomas.stu...@gmail.com> Sent: Montag, 24. Februar 2020 14:41 To: Doerr, Martin <martin.do...@sap.com> Cc: core-libs-...@openjdk.java.net; Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Langer, Christoph <christoph.lan...@sap.com> Subject: Re: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element   Oh okay. Then it looks okay to me.   Cheers, Thomas   On Mon, Feb 24, 2020 at 12:56 PM Doerr, Martin <martin.do...@sap.com> wrote: Hi Thomas,   thanks for the quick review.   ATTRIBUTE_ALIGNED is defined in hotspot. I can’t use it for src/jdk.jdwp.agent/share/native/libjdwp/ArrayReferenceImpl.c.   Christoph had already suggested to make it available for core libs, too, but I haven’t found a good place for it.   Best regards, Martin     From: Thomas Stüfe <thomas.stu...@gmail.com> Sent: Montag, 24. Februar 2020 12:52 To: Doerr, Martin <martin.do...@sap.com> Cc: core-libs-...@openjdk.java.net; Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Langer, Christoph <christoph.lan...@sap.com> Subject: Re: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element   Hi Martin,   maybe use ATTRIBUTE_ALIGNED instead?   Cheers, Thomas   On Mon, Feb 24, 2020 at 12:44 PM Doerr, Martin <martin.do...@sap.com> wrote: Hi,   we had fixed stack array alignment for Windows 32 bit with JDK-8220348. However, there are also stack allocated jlong and jdouble used as source for SetLongArrayRegion and SetDoubleArrayRegion with insufficient alignment for this platform.   Here’s my proposed fix: http://cr.openjdk.java.net/~mdoerr/8239856_win32_long_double_align/webrev.00/   Please review.   Best regards, Martin