Hi Mandy,
Thank you for the update!
I like it as it is a good compromise.
I do not see any wording issues.
Thanks,
Serguei
On 4/18/20 15:28, Mandy Chung wrote:
Hi Chris, Serguei,
On 4/18/20 12:18 AM, Chris Plummer wrote:
Yes. I'd like to see all this as part of the Class/Classloading spec
in some sort of section that gives an overview of all these topics,
but mostly clarifies what an initiating loader is, and the (non)
relationship to hidden classes.
We should refer initiating loader and class loading from JVMS 5.3.
JVM TI needs the clarification w.r.t. GetClassLoaderClasses that does
not include hidden classes because the initiating class loader cannot
find it.
GetLoadedClasses is about class creation. While it seems tempted to
put the descriptions in some sort of overview section, I found the
clarification is specific for each function and hence inlining them in
each function helps the readers directly see the difference.
I made a few changes that should ease your concern of duplication:
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.06-svc-spec-changes.01/
- The class creation description added in GetLoadedClasses. Not in
JDWP, JDI and Instrumentation.
- The description in GetClassLoaderClasses,
Instrumentation::getInitiatedClasses,
ClassLoaderReference::visibleClasses is revised to take out the
details. Add links from JDWP and JDI to GetClassLoaderClasses.
- The details about hidden classes can be found from `Class::isHidden`
and `Lookup::defineHiddenClass`.
Mandy
