http://cr.openjdk.java.net/~iignatyev//8243568/webrev.00 > 8 lines changed: 0 ins; 6 del; 2 mod;
Hi all, could you please review this small and trivial patch which updates serviceability/logging/TestLogRotation.java test to pass both 'test.java.opts' and not 'test.vm.opts' ? to do that, the patch removes the custom logic of handling test.java.opts and just uses ProcessTools.createJavaProcessBuilder(boolean addTestVmAndJavaOptions=true, String...), which prepends values of both properties. from JBS: > serviceability/logging/TestLogRotation.java test use 'test.java.opts' to get > external vm flags, yet actually external flags are split b/w 'test.java.opts' > and 'test.vm.opts' and in the majority of cases all external flags are set > listed in 'test.vm.opts' so the test should be updated to read both. JBS: https://bugs.openjdk.java.net/browse/JDK-8243568 webrev: http://cr.openjdk.java.net/~iignatyev//8243568/webrev.00 Thanks, -- Igor
