Hi Serguei,
LGTM,
-- Igor
> On Apr 27, 2020, at 8:52 PM, serguei.spit...@oracle.com wrote:
>
> Please, review small patch to fix the build regression caused by fix of
> 8242237.
>
> Patch:
>
> diff --git
> a/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp
>
> b/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp
> ---
> a/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp
> +++
> b/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp
> @@ -242,7 +242,7 @@
>
> /* Process a CLASS_LOAD or aClassPrepare event. */
> static void process_class_event(jvmtiEnv* jvmti, JNIEnv* jni, jclass klass,
> - int* event_count_ptr, const char*
> event_name) {
> + jint* event_count_ptr, const char*
> event_name) {
> char* sig = NULL;
> char* gsig = NULL;
> jvmtiError err;
>
>
> Summary:
> Windows Compiler reports errors when a parameter is declared as 'int*' but
> jint* is actually used in the calls:
>
> ./open/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp(271):
> error C2664: 'void process_class_event(jvmtiEnv *,JNIEnv *,jclass,int
> *,const char *)': cannot convert argument 4 from 'jint *' to 'int *'
> ./open/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp(271):
> note: Types pointed to are unrelated; conversion requires reinterpret_cast,
> C-style cast or function-style cast
>
>
> Testing:
> A mach5 job build-tier1 submitted.
>
> Thanks,
> serguei
