Thanks, David!
Serguei
On 6/12/20 00:27, David Holmes wrote:
On 12/06/2020 4:02 pm, serguei.spit...@oracle.com wrote:
Hi Leonid,
It looks okay to me.
> I find this whole MBean vs MXBean terminology very confusing. :)
Me too. :)
For instance, I see some references to MBeanServer (should they also
be replaced with MXBeanServer?):
No. There is no MXBeanServer.
This attempts to shed some light on everything:
https://docs.oracle.com/en/java/javase/14/docs/api/java.management/javax/management/MXBean.html
"An MXBean is a kind of MBean. An MXBean object can be registered
directly in the MBean Server, or it can be used as an argument to
StandardMBean and the resultant MBean registered in the MBean Server."
Cheers,
David
-----
http://cr.openjdk.java.net/~lmesnik/8242328/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/monitoring/CompilationMXBean/comptimemon002/TestDescription.java.udiff.html
* The test checks that
- * CompilationMBean.isCompilationTimeMonitoringSupported()
+ * CompilationMXBean.isCompilationTimeMonitoringSupported()
* method returns true. The test performs access to management
metrics
* through default*MBeanServer*.
http://cr.openjdk.java.net/~lmesnik/8242328/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/monitoring/CompilationMXBean/comptimemon003/TestDescription.java.udiff.html
* The test checks that
- * CompilationMBean.isCompilationTimeMonitoringSupported()
+ * CompilationMXBean.isCompilationTimeMonitoringSupported()
* method returns true. The test performs access to management
metrics
* through custom*MBeanServer* (developed and saved in
http://cr.openjdk.java.net/~lmesnik/8242328/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/monitoring/CompilationMXBean/comptimemon004/TestDescription.java.udiff.html
* DESCRIPTION
* The test checks that
- * CompilationMBean.isCompilationTimeMonitoringSupported()
+ * CompilationMXBean.isCompilationTimeMonitoringSupported()
* method returns true. The test performs access to management
metrics
* through default*MBeanServer* proxy.
http://cr.openjdk.java.net/~lmesnik/8242328/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/monitoring/CompilationMXBean/comptimemon005/TestDescription.java.udiff.html
* The test checks that
- * CompilationMBean.isCompilationTimeMonitoringSupported()
+ * CompilationMXBean.isCompilationTimeMonitoringSupported()
* method returns true. The test performs access to management
metrics
* through custom*MBeanServer* proxy (developed and saved in
Thanks,
Serguei
On 6/11/20 16:48, David Holmes wrote:
Hi Leonid,
On 12/06/2020 7:09 am, Leonid Mesnik wrote:
Hi
Could you review following fix which change leftovers of
ThreadMBean to ThreadMXBean. In the most cases the comments were
updated only.
webrev: http://cr.openjdk.java.net/~lmesnik/8242328/webrev.00/
Looks good!
I find this whole MBean vs MXBean terminology very confusing. :)
Thanks,
David
bug: https://bugs.openjdk.java.net/browse/JDK-8242328
Leonid
