+1

Mandy

On 6/22/20 4:55 PM, Jonathan Gibbons wrote:

Please review a small change to fix an unresolved reference in `@throws IOException`.

The problem is that the method signature uses a fully-qualified name for `java.io.IOException` instead of importing it. meaning that the `@throws` cannot resolve the name. Although this could be fixed by using a fully-qualified name in `@throws` as well, a better, more conventional solution is to import that name and use the simple name in both places.

-- Jon

JBS: https://bugs.openjdk.java.net/browse/JDK-8248061

Patch:


$ hg diff -R open open/src/jdk.management
diff -r 9cfa0137612f src/jdk.management/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java --- a/src/jdk.management/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java Mon Jun 22 13:37:41 2020 -0700 +++ b/src/jdk.management/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java Mon Jun 22 16:07:38 2020 -0700
@@ -25,6 +25,7 @@

 package com.sun.management;

+import java.io.IOException;
 import java.lang.management.PlatformManagedObject;

 /**
@@ -72,7 +73,7 @@
      * method denies write access to the named file
      * or the caller does not have ManagmentPermission("control").
      */
- public void dumpHeap(String outputFile, boolean live) throws java.io.IOException; + public void dumpHeap(String outputFile, boolean live) throws IOException;

     /**
      * Returns a list of {@code VMOption} objects for all diagnostic options.



Reply via email to