Re: [15] RFR(XS): 8247730: 2 JNI exception pending defect groups in DwarfParser.cpp

[serguei.spit...@oracle.com]

On 6/23/20 14:57, serguei.spit...@oracle.com wrote:

Hi Chris,

+    if (!env->ExceptionOccurred()) {
     env->ThrowNew(ex_cls, "DWARF not found");
+    }

Should the !env->ExceptionOccurred() be replaced with env->ExceptionOccurred() ?

Sorry. It is correct as it is is.
But then the question is what happen in the case of env->ExceptionOccurred() ?

Thanks,
Serguei

Thanks,
Serguei
 

On 6/23/20 11:38, Chris Plummer wrote:

Hello,

Please review the following:

https://bugs.openjdk.java.net/browse/JDK-8247730
http://cr.openjdk.java.net/~cjplummer/8247730/webrev.00/

There are two locations were we make a JNI call with the possibility of a pending exception. This is new code in JDK 15, so it is being addressed there.

thanks,

Chris