A typo:
inital
---
I would think you might get a few samples, so maybe check
sampledEvents > numThreads/2
or am I misunderstanding?
+ int sampledEvents = HeapMonitor.sampledEvents();
+ if (sampledEvents > 0) {
+ throw new RuntimeException(
+ "Sampling the inital allocation too many times: " + sampledEvents);
---
Maybe add the word "always" ?
@summary Verifies the JVMTI Heap Monitor does not sample the first object.
On Thu, Jun 25, 2020 at 11:06 AM Jean Christophe Beyler
<jcbey...@google.com> wrote:
>
> Hi all!
>
> I hope you are all doing well!
>
> I have a small review request to fix initialization of the heap sampler's
> byte left variable:
> http://cr.openjdk.java.net/~jcbeyler/8247615/webrev.00/
>
> The bug is here:
> https://bugs.openjdk.java.net/browse/JDK-8247615
>
> Note, this passed the submit repo testing.
>
> Thanks and have a great day!
> Jc
